Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve RegistryAccess directly from the server for caster tome registry #1609

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

62832
Copy link
Contributor

@62832 62832 commented Jan 27, 2025

Rather than trying to make use of a specific Overworld level from the started server for CasterTomeRegistry and doing so only for a RegistryAccess, it would make more sense for the latter to be retrieved directly from the started server itself independently of any level.

In situations such as when using the test server provided by NeoForge and ModDevGradle for unit testing, this prevents any such test runs from crashing and hanging due to the fact that the test server doesn't have any levels to speak of and returns null when trying to retrieve them, which up until now was never checked or accounted for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant